Bump testVersion to PHP 8.2 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should bump the test version to 8.2 to stay in line with PHP LTS supported versions and to keep our CI command clean and simple to understand. The alternative is to change the PHP at run time like this: phpcs . --runtime-set testVersion 8.2-.
Closes #45
Changelog Entry
Changed - Bump PHP test version to 8.2
Credits
@claytoncollie
Checklist:
I agree to follow this project's Code of Conduct.
I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests pass.
Upgrade Path
For projects using this repository with a composer.json file, you should be referencing the dev-master branch like so, "10up/phpcs-composer": "dev-master" which means to get the latest version, you need to delete your composer.lock file and then re-install your dependencies with composer install
Once you have the latest version of this repository pulled in, make sure to remove the testVersion flag in your terminal command. Meaning that if you have phpcs . --runtime-set testVersion 8.1-, the command can now be simplified to phpcs .. You should now be linting against PHP version 8.2 and below.