Added the ability to change player skin #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ability to change the player skin from the sidebar settings panel. Now users will be able to select different skins from the predefined list of skins (4 at the moment) and if they want to use any custom skin they can do so by toggling the swicth on and adding any custom skin URL in the input fields. Also added the thumbnails for the predefined skins for better user experience.
jeffpaul
requested review from
a team,
dinhtungdu and
Sidsector9
and removed request for
jeffpaul,
a team and
dinhtungdu
|
@Sidsector9 reminder on PR review here |
Sidsector9
requested changes
Oct 11, 2022
src/edit.js
Outdated
| @@ -77,6 +77,15 @@ function Edit( props ) { | |||
| [ clientId ] | |||
| ); | |||
|
|
|||
| const [ useCustomUrl, setUseCustomUrl ] = useState( false ); | |||
There was a problem hiding this comment.
Thanks for working on this!
Because the hook is called after a return, that makes it conditional and violates the usage rules of hooks.
Can you move useState to before line 58?
There was a problem hiding this comment.
@Sidsector9 Makes sense. done. Thanks!
Sidsector9
requested changes
Oct 11, 2022
src/edit.js
Outdated
| <div className="preview-wrapper"> | ||
| { defaultSkins.length && defaultSkins.map( ( skin, index ) => { | ||
| return ( | ||
| <label key={ index } className="winamp-radio-wrapper"> |
There was a problem hiding this comment.
Would be good to add htmlFor to associate with the following input element.
There was a problem hiding this comment.
@Sidsector9 Done as well.
Sidsector9
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Added the ability to change the player skin from the sidebar settings panel. Now users will be able to select different skins from the predefined list of skins (4 at the moment), for designs please see #1
Additionally, if users want to use any custom skin they can do so by toggling the switch on and adding any custom skin URL in the input field. Also added the thumbnails for the predefined skins for better user experience.
Closes #5
How to test the Change
Here's a screenshot:
When using custom skin input:
Changelog Entry
Credits
Props @jeffpaul @dkotter @zamanq
Checklist: