Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Fixes issue to work with Gutenberg 4.7.0 #18

Merged
merged 3 commits into from
Jan 10, 2019
Merged

Conversation

ChaosExAnima
Copy link
Contributor

Removes references to deprecated store for core/notices

@ChaosExAnima
Copy link
Contributor Author

@mphillips - As a note, I also had some issues compiling this project without updating Babel and Webpack. Do you see the same thing?

@mphillips
Copy link
Contributor

@ChaosExAnima I wasn't able to compile either, but running npm install fixed it for me.

While testing, I don't see the notice text being displayed. Do you see the same? https://cloudup.com/cyKOZdnZdJa

@adamsilverstein
Copy link

While testing, I don't see the notice text being displayed. Do you see the same? https://cloudup.com/cyKOZdnZdJa

I think the notice api now expects a string rather than an object.

@ChaosExAnima
Copy link
Contributor Author

@mphillips - Correct, seems to rely on a string now: https://wordpress.org/gutenberg/handbook/designers-developers/developers/data/data-core-notices/#createsuccessnotice I'll update when I get a minute.

I'm also noting that the admin_notices hook is now supported, so it may be worth considering switching to that to allow theme modification. Thoughts?

@ChaosExAnima
Copy link
Contributor Author

Okay, that was an easy fix:
screenshot from 2019-01-02 11-23-25

Can you verify?

@mphillips
Copy link
Contributor

@ChaosExAnima I still see the same issue. I believe dist/main.js needs to be updated along with your last commit. Also, dumb question, but how are you updating dist/main.js. I don't see a grunt task to do that, but I must be missing something. :)

@ChaosExAnima
Copy link
Contributor Author

ChaosExAnima commented Jan 8, 2019

@mphillips - Whoops, my bad! I've been using scripts in package.json. yarn build works quite well here?

@mphillips mphillips merged commit 7d15814 into master Jan 10, 2019
@mphillips
Copy link
Contributor

@ChaosExAnima Works well in my testing now. Merged!

@jeffpaul jeffpaul deleted the fix/gutenberg-4.7.0 branch December 3, 2020 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants