Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Update: WPSnapshots local copy #32

Merged
merged 2 commits into from
Jan 15, 2021

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

Due to the new flag introduced in 10up/wpsnapshots#71, when running WPAcceptance locally against a cached environment, the process will be hung with the prompt asking if we want to overwrite local snapshot or not.

This PR fixes that bug by adding the flag to the command called by wpacceptance.

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

@jeffpaul jeffpaul requested a review from tlovett1 October 5, 2020 19:36
@jeffpaul jeffpaul added this to the 0.16.9 milestone Oct 5, 2020
@felipeelia
Copy link
Member

@dinhtungdu while testing things for ElasticPress I had a similar problem but when we don't have the snapshot already downloaded. It will wait for the user to answer if it should download files and/or database but as nothing is inputted it just times out.

I've tested adding --include_files --include_db to that command and that seemed to do the trick.

Thoughts? Do you think we can include these flags in this PR too? Thanks!

@tlovett1 tlovett1 merged commit 516b335 into 10up:master Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants