Remove the --column-statistics=0 --no-tablespaces
params
#68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR reverts some of the changes introduced in #66 and is supposed to be just a hotfix, as we have an underlying issue that still needs to be solved.
The
--column-statistics=0 --no-tablespaces
parameters make sense while using newer versions of mysqldump. In WP Local Docker we are using v5.5. WP Local Docker ultimately extends debian:buster and stated here it doesn't content recent versions of mysql-client tools.Alternate Designs
Hopefully, we can develop a solution that conditionally adds those parameters based on the mysqldump version being used.
Benefits
WP Snapshots working again on WP Local Docker.
Possible Drawbacks
It generates some errors for users using it outside WP Local Docker (and with newer versions of mysqldump)
Verification Process
It's very difficult to test this, so I'm just reverting the mysqldump calls to what they were before.
Checklist:
Applicable Issues
Changelog Entry