Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the --column-statistics=0 --no-tablespaces params #68

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

felipeelia
Copy link
Member

Description of the Change

This PR reverts some of the changes introduced in #66 and is supposed to be just a hotfix, as we have an underlying issue that still needs to be solved.

The --column-statistics=0 --no-tablespaces parameters make sense while using newer versions of mysqldump. In WP Local Docker we are using v5.5. WP Local Docker ultimately extends debian:buster and stated here it doesn't content recent versions of mysql-client tools.

Alternate Designs

Hopefully, we can develop a solution that conditionally adds those parameters based on the mysqldump version being used.

Benefits

WP Snapshots working again on WP Local Docker.

Possible Drawbacks

It generates some errors for users using it outside WP Local Docker (and with newer versions of mysqldump)

Verification Process

It's very difficult to test this, so I'm just reverting the mysqldump calls to what they were before.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@dustinrue
Copy link
Contributor

Also putting in my vote to have --column-statistics=0 --no-tablespaces as it is also not present in MariaDB 10.3.x releases which is what all the current major Linux operating systems use by default (Ubuntu, Debian and CentOS/RHEL)

@jeffpaul jeffpaul requested a review from tlovett1 September 1, 2020 15:59
@jeffpaul jeffpaul added this to the 2.0.2 milestone Sep 1, 2020
@tlovett1 tlovett1 merged commit 6aa9c7d into 10up:develop Sep 9, 2020
@jeffpaul jeffpaul modified the milestones: 2.0.2, 2.1.0 Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants