Minor cleanup for #90

11ty · Sep 4, 2024 · ea09909 · ea09909
1 parent d165193
commit ea09909
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/client/reload-client.js b/client/reload-client.js
@@ -225,13 +225,19 @@ class EleventyReload {
                   },
                   addChild: function(parent, child) {
                     // Declarative Shadow DOM https://github.com/11ty/eleventy-dev-server/issues/90
-                    if(child.nodeName === "TEMPLATE" && child.hasAttribute("shadowrootmode") && parent.shadowRoot) {
-                      for(let oldChild of parent.shadowRoot?.childNodes || []) {
-                        oldChild.remove();
+                    if(child.nodeName === "TEMPLATE" && child.hasAttribute("shadowrootmode")) {
+                      let root = parent.shadowRoot;
+                      if(root) {
+                        // remove all shadow root children
+                        while(root.firstChild) {
+                          root.removeChild(root.firstChild);
+                        }
                       }
                       for(let newChild of child.content.childNodes) {
-                        parent.shadowRoot.appendChild(newChild);
+                        root.appendChild(newChild);
                       }
+                    } else {
+                      parent.appendChild(child);
                     }
                   },
                   onNodeAdded: function (node) {