Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop node-fetch and bump engines.node to >= 18 #37

Merged
merged 2 commits into from
May 13, 2024
Merged

Drop node-fetch and bump engines.node to >= 18 #37

merged 2 commits into from
May 13, 2024

Conversation

uncenter
Copy link
Contributor

@uncenter uncenter commented Jan 9, 2024 •
edited
Loading

11ty itself is now requiring a minimum of Node 18, and upgrading here as well unlocks the native fetch Web API (https://nodejs.org/en/blog/announcements/v18-release-announce#fetch-experimental) which means we can drop node-fetch.

@zachleat zachleat merged commit 3f51ee2 into 11ty:master May 13, 2024
@zachleat zachleat added this to the Eleventy Fetch v5.0.0 milestone May 13, 2024
@zachleat
Copy link
Member

Thank you!! This one is awesome!

@uncenter uncenter deleted the drop-node-fetch branch May 13, 2024 13:38
@zachleat zachleat mentioned this pull request May 13, 2024
Closed
@zachleat zachleat added breaking change This will have to be included with a major version as it breaks backwards compatibility. enhancement New feature or request labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change This will have to be included with a major version as it breaks backwards compatibility. enhancement New feature or request
Projects
None yet
Milestone
Eleventy Fetch v5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@uncenter @zachleat