Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default vite options for Vite v3 #12

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Update default vite options for Vite v3 #12

merged 1 commit into from
Jul 16, 2022

Conversation

vivgui
Copy link
Contributor

@vivgui vivgui commented Jul 16, 2022

CleanShot 2022-07-15 at 21 28 15@2x

It seems Vite v3 deprecated string values for server.middlewareMode, it's a boolean now. The config value should be true now.

Also, we need to add appType as a shared config, the value should be custom according to the docs.

Let me know if you want me to amend anything.

@zachleat zachleat merged commit 3a2ae8c into 11ty:main Jul 16, 2022
@zachleat
Copy link
Member

Thank you!

Copy link

@wommy wommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add appType: "custom" in the readme?

and can we get version bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants