Nunjucks Shortcode output is escaped when using Nunjucks + Markdown

[zachleat]

Reported by @hankchizljaw here: https://github.com/hankchizljaw/webcomponents.club

[Andy-set-studio]

Some context for when you have a look:

Markdown: https://github.com/hankchizljaw/webcomponents.club/blob/master/journal/001-the-start.md ({% video %})
Shortcode: https://github.com/hankchizljaw/webcomponents.club/blob/master/shortcodes/video-shortcode.js

[zachleat]

As we discovered, this is because your shortcode has extra whitespace!

See: https://github.com/hankchizljaw/webcomponents.club/blob/master/shortcodes/video-poster-shortcode.js

As noted on https://commonmark.org/help/ indent 4 spaces triggers a code block in markdown.

So changing

let response = `
        <a href="${shareUrl}" aria-label="Watch this video on Youtube">
            …
        </a>
    `;

to

let response = `
<a href="${shareUrl}" aria-label="Watch this video on Youtube">
    …
</a>`;

will fix it!

[Andy-set-studio]

Thanks @zachleat, hopefully this will help someone out in the long-term who finds themselves in a similar pickle 🙂

[zachleat]

@hankchizljaw yes! It wasn't immediately obvious to me what was happening so I'm sure someone else will run into it too 👍🏻

[eeeps]

it me 🥒🏃‍♂️