-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New deprecation warnings stemming from recursive-copy@^2.0.14
#3299
Comments
recursive-copy@^2.0.14
recursive-copy@^2.0.14
As an addendum: I recently learned that there's a native API for recursive copying in NodeJS that was introduced back in Node 16 (along with a promisified version too), however even as of v22 it's still labeled as "Experimental", so might not be the right thing to lean on if Eleventy's policy is to only use native API's that are stable. Just thought I'd add it as an afterthought here since it seemed relevant. |
Confirmed this, filed upstream first: timkendrick/recursive-copy#44 |
Lovely visualization here of the dep graph: https://npmgraph.js.org/?q=%4011ty%2Feleventy%40canary#select=exact%3Arecursive-copy%402.0.14 |
Hmm -- the upstream project seems to have limited activity, and no releases for over 2 years. I think fs-extra could be used instead here... any thoughts? I suspect this would be a breaking change so perhaps best to get into v3 if it's not too late. |
@BenjaminEHowe I think we’ll temporarily fork this one and hopefully move to |
We’re now using Shipping with 3.0.0-alpha.17. |
Operating system
macOS Sonoma 14.2.1 (23C71)
Eleventy
@11ty/eleventy@3.0.0-alpha.10
Describe the bug
As of writing this issue, I'm seeing new deprecation warnings for the following packages:
npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful. npm warn deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
Upon further investigation, I can see that these deprecated packages stem from
recursive-copy@^2.0.14
which hasn't been touched for the past 2 years.recursive-copy
is a direct dependency of Eleventy as of the latest canary (3.0.0-alpha.10
). Here's a copy of the dependency tree:@11ty/eleventy 3.0.0-alpha.10 └─┬ recursive-copy 2.0.14 # <-- hasn't been updated, below dependencies are deprecated └─┬ rimraf 2.7.1 └─┬ glob 7.2.3 └── inflight 1.0.6
Reproduction steps
npm init -y
npm install @11ty/eleventy@canary
Expected behavior
Warnings about deprecated packages should not be thrown.
Reproduction URL
No response
Screenshots
No response
The text was updated successfully, but these errors were encountered: