eleventyComputed added via config does not follow deep data merge

[LeaVerou]

(Thanks @DmitrySharabin for debugging this issue!)

I was using two plugins, both of which were doing something like this.

Plugin 1:

config.addGlobalData("eleventyComputed", {
	foo (data) {
		// stuff
	}
});

Plugin 2:

config.addGlobalData("eleventyComputed", {
	bar (data) {
		// stuff
	}
});

I expected that deep data merge should take care of merging the objects, but it turned out that each plugin was overriding the previous one.

a) This shouldn't happen and
b) Is there a better way for plugins to add global computed data?

[zachleat]

I’ll update the docs but addGlobalData does take a lodash set selector.

The awkward part of addGlobalData is that when you pass in a function we’ll run it so when you want to return a function as part of eleventyComputed you need to nest it, like so:

config.addGlobalData("eleventyComputed.foo", () => {
	return (data) => { /* stuff */ };
});
config.addGlobalData("eleventyComputed.bar", () => {
	return (data) => { /* stuff */ };
});

I would like to improve that for eleventyComputed specifically but I don’t see a clear path forward yet that won’t break stuff.

The problem is this section right here:

eleventy/src/Data/TemplateDataInitialGlobalData.js

Lines 27 to 29 in e45040e

	if (typeof returnValue === "function") {
	returnValue = await returnValue();
	}

[zachleat]

Oh, I forgot to say to your original point: I agree that we should merge objects passed to addGlobalData so I’ll work on that change too.

[zachleat]

Merging of objects passed to addGlobalData will ship with 3.0.0-alpha.18

[zachleat]

One more note here is that this will happen independent of whether or not deep data merge is enabled. We’re trying to phase out/discourage use of the dataDeepMerge feature.

[zachleat]

Docs are updated: https://www.11ty.dev/docs/data-global-custom/

[LeaVerou]

Wow, that was fast! Color me impressed!