refactor(loops): Clean up some loops #3362
Open
+37
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zachleat Beep! :) |
ajitzero
reviewed
Aug 11, 2024
| @@ -212,7 +212,7 @@ class Template extends TemplateContent { | |||
| let results = await Promise.all(promises); | |||
|
|
|||
| permalinkValue = {}; | |||
| for (let j = 0, k = keys.length; j < k; j++) { | |||
| for (let j = 0; j < keys.length; j++) { | |||
There was a problem hiding this comment.
question: Extracting the length into a variable used to be a performance improvement thing. Is that irrelevant now with newer browser versions?
| continue; | ||
| } | ||
|
|
||
| for (let item of this.collectionsData[collectionName]) { | ||
| for (let item of collectionData) { |
There was a problem hiding this comment.
question: Is Line 674 still working as expected? Is there a test for it?
|
|
||
| let matches = paths.filter((path) => { | ||
| return !this.extensionMap.hasEngine(path); | ||
| }); | ||
| return matches; |
There was a problem hiding this comment.
nit: We might as well return it inline :)
zachleat
requested changes
Aug 30, 2024
| for (let path of this.extensionMap.getPassthroughCopyGlobs(this.inputDir)) { | ||
| paths.add(path); | ||
| } | ||
| let paths = new Set( |
There was a problem hiding this comment.
Fine with almost all of the style changes here except the .concat ones. I prefer the old method, sorry :-/
| uniqueIgnores.add(ignore); | ||
| } | ||
| let uniqueIgnores = new Set( | ||
| this.fileIgnores |
zachleat
added
the
needs-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of small tweaks. Usually to make loops easier to read, and sometimes to replace a loop with something that is (hopefully) easier or faster to read.