Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wildcard in extensions argument in .addPreprocessor() #3418

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

vrugtehagel
Copy link
Contributor

The second argument in .addPreprocessor() seems to be designed to allow "*" to match all templating languages, but gets mapped to ".*" before the actual comparison to "*" happens. As such, it is impossible to match all file types.

@vrugtehagel vrugtehagel requested a review from zachleat as a code owner August 18, 2024 12:48
Copy link
Member

@zachleat zachleat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachleat
Copy link
Member

This will ship with 3.0.0-alpha.19 and 3.0.0-beta.2.

@zachleat zachleat merged commit 75d01f9 into 11ty:main Aug 30, 2024
9 checks passed
@zachleat zachleat added this to the Eleventy 3.0.0 milestone Aug 30, 2024
@zachleat
Copy link
Member

Originally at #188

zachleat added a commit that referenced this pull request Aug 30, 2024
@vrugtehagel vrugtehagel deleted the patch-1 branch August 30, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants