Gloryofrobots data hooks via #635 #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main changes are in TemplateData. User config uses new Map() to store pairs (extension, parser) where parser is a function receiving file contents in string and returning data object. Later declared parsers have priority over first ones.
All test data are in test/stubs-630/. Tests are focused on loading local and global custom data (yaml and nosj) and checking format priority order. From top to bottom it must be js-json-nosj-yaml, in the case where nosj declared after yaml (nosj is a simple JSON file) js-yaml added to devDependencies
…into gloryofrobots-data-hooks # Conflicts: # src/TemplateData.js
Closed
This was referenced Nov 27, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #635 for original comments. Fixes #630.