Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce lombok to models #117

Merged
merged 3 commits into from
Mar 28, 2024
Merged

feat: introduce lombok to models #117

merged 3 commits into from
Mar 28, 2024

Conversation

NuttyShrimp
Copy link
Member

No description provided.

@NuttyShrimp NuttyShrimp requested a review from FKD13 March 25, 2024 22:35
FKD13
FKD13 reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@FKD13 FKD13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Can we resolve the issue with the isBroken?

src/main/java/telraam/database/models/Baton.java
Comment on lines -10 to -12
// DO NOT REMOVE
public Baton() {
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can this not be removed, and why did u remove it 😅
Maybe keep this comment if we found out what it is for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it because it is replaced with the @NoArgsConstructor. It think JDBI needs it to create the object after fetching it from the DB (and then changes the values via setters)

@FKD13
Copy link
Member

FKD13 commented Mar 27, 2024

Also, rebase on development to get the latest CI change here?

@FKD13
Copy link
Member

FKD13 commented Mar 27, 2024

Fixed the test for you :D

@NuttyShrimp
Copy link
Member Author

So as you can see in the CI, that test fails for some unknown reason with that setIsBroken setter removed. And I have no clue why, a wild guess would be that the mapping from the DB goes wrong for some reason, can't seem to find any other reason

@FKD13
Copy link
Member

FKD13 commented Mar 27, 2024

When replacing isBroken by simply broken, it does work again

@NuttyShrimp
Copy link
Member Author

Well I got some mapping errors if I did that

FKD13
FKD13 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@FKD13 FKD13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the tests work! @Topvennie jij meningen hierover?

@FKD13 FKD13 requested a review from Topvennie March 27, 2024 23:52
Topvennie
Topvennie approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@Topvennie Topvennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@NuttyShrimp NuttyShrimp merged commit 25ae5cc into development Mar 28, 2024
1 check passed
@NuttyShrimp NuttyShrimp deleted the add-lombok branch March 28, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Topvennie Topvennie Topvennie approved these changes

@FKD13 FKD13 FKD13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NuttyShrimp @FKD13 @Topvennie