Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: Add @yincrash's windows install package #12

Closed
wants to merge 1 commit into from
Closed

windows: Add @yincrash's windows install package #12

wants to merge 1 commit into from

Conversation

DeeDeeG
Copy link
Contributor

@DeeDeeG DeeDeeG commented Jan 29, 2017

Adds an install process to replace Emoji on Windows.
It merges the Twemoji font with Segoe UI Symbol on the user's machine,
and replaces Segoe UI Emoji as well on Win 8 and 10.

An uninstall script is also included to assist the user in restoring
the original Windows fonts.

README also updated.

Fixes #9

Adds an install process to replace Emoji on Windows.
It merges the Twemoji font with Segoe UI Symbol on the user's machine,
and replaces Segoe UI Emoji as well on Win 8 and 10.

An uninstall script is also included to assist the user in restoring
the original Windows fonts.

README also updated.

Fixes #9
@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Jan 29, 2017

I would like to mention some minor changes that were made in the files, beyond replacing the text "emojione" with "twemoji" or "Twitter Color Emoji." Some of these changes are not reflected in diffs, since they occur in sections of files that are completely new to this repository.

Changes are:

  • Version numbers in the project (i.e. in README.md and Makefile) are changed from 1.1 -> 1.2, anticipating a new release after this pull request would be accepted.

  • Also included a bump to the Python version number mentioned in the instructions, 3.5 -> 3.6, line 173 of README.md , as users following the instructions will end up downloading this version.

  • Fixed a minor typo in a URL at line 175 of the new README.md, effectively "TwitterColorEmoji-SVGinOT-1.2-Win.zip" -> "TwitterColorEmoji-SVGinOT-Win-1.2.zip"

  • Fixed a potential grammar error in a comment located at lines 89 and 95 in the new install.cmd:
    "It is not overwritten" (used to be displayed in every case) -> "It is not overwritten" (now displayed when referring to just one font) "They are not overwritten" (now displayed when referring to both fonts).

@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Jan 29, 2017

@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Jan 29, 2017

I fixed a couple issues with this pull request, and re-submitted here: #13

@DeeDeeG DeeDeeG closed this Jan 29, 2017
@13rac1
Copy link
Owner

13rac1 commented Jan 29, 2017

No need to close PRs. Amend your commits and force push the changes to your branch/fork. ;)

git add changed-file
git commit --amend
git push -f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants