Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back dad jokes #560

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Bring back dad jokes #560

merged 3 commits into from
Nov 20, 2024

Conversation

mgwalker
Copy link
Member

The fatherhood.gov API is now behind a captcha and rather than embrace a dark pattern of defeating the captcha, for this PR I manually copied the full list of jokes and turned them into a simple JSON file. Now we can use that. Dad jokes are back.


Checklist:

  • Code has been formatted with prettier

N/A:

  • The OAuth wiki
    page has been updated if Charlie needs any new OAuth events or scopes
  • The Environment Variables
    wiki page has been updated if new environment variables were introduced
    or existing ones changed
  • The dev wiki has been updated, e.g.:
    • local development processes have changed
    • major development workflows have changed
    • internal utilities or APIs have changed
    • testing or deployment processes have changed
  • If appropriate, the NIST 800-218 documentation has been updated

@mgwalker mgwalker requested a review from a team as a code owner November 13, 2024 23:04
@mgwalker mgwalker merged commit c776946 into main Nov 20, 2024
7 checks passed
@mgwalker mgwalker deleted the mgwalker/dad-jokes branch November 20, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant