LG-13657 - Prep to remove IPP FSM, set controller feature flag in test

changelog: Internal, In-person proofing, Set state id controller feature flag to true in test

config/application.yml.default

@@ -526,6 +526,7 @@ test:
   hmac_fingerprinter_key: a2c813d4dca919340866ba58063e4072adc459b767a74cf2666d5c1eef3861db26708e7437abde1755eb24f4034386b0fea1850a1cb7e56bff8fae3cc6ade96c
   hmac_fingerprinter_key_queue: '["old-key-one", "old-key-two"]'
   identity_pki_disabled: true
+  in_person_state_id_controller_enabled: true
   lexisnexis_trueid_account_id: 'test_account'
   lockout_period_in_minutes: 5
   logins_per_email_and_ip_limit: 2

spec/controllers/idv/in_person/address_controller_spec.rb

@@ -48,6 +48,11 @@
       end
 
       context 'in_person_state_id_controller_enabled is not enabled' do
+        before do
+          allow(IdentityConfig.store).to receive(:in_person_state_id_controller_enabled).
+            and_return(false)
+        end
+
         it 'redirects to state id page if not complete' do
           subject.user_session['idv/in_person'][:pii_from_user].delete(:identity_doc_address1)
           get :show

spec/controllers/idv/in_person_controller_spec.rb

@@ -56,7 +56,7 @@
           it 'redirects to the first step' do
             get :index
 
-            expect(response).to redirect_to idv_in_person_step_url(step: :state_id)
+            expect(response).to redirect_to idv_in_person_proofing_state_id_path
           end
 
           it 'has non-nil presenter' do
@@ -82,7 +82,7 @@
               it 'redirects to the first step' do
                 get :index
 
-                expect(response).to redirect_to idv_in_person_step_url(step: :state_id)
+                expect(response).to redirect_to idv_in_person_proofing_state_id_path
               end
             end
           end

spec/features/idv/analytics_spec.rb

@@ -509,10 +509,10 @@
         flow_path: 'standard', opted_in_to_in_person_proofing: false
       },
       'IdV: in person proofing state_id visited' => {
-        step: 'state_id', flow_path: 'standard', step_count: 1, analytics_id: 'In Person Proofing'
+        step: 'state_id', flow_path: 'standard', analytics_id: 'In Person Proofing'
       },
       'IdV: in person proofing state_id submitted' => {
-        success: true, flow_path: 'standard', step: 'state_id', step_count: 1, analytics_id: 'In Person Proofing', errors: {}, same_address_as_id: false, birth_year: '1938', document_zip_code: '12345'
+        success: true, flow_path: 'standard', step: 'state_id', analytics_id: 'In Person Proofing', errors: {}, same_address_as_id: false, birth_year: '1938', document_zip_code: '12345'
       },
       'IdV: in person proofing address visited' => {
         step: 'address', flow_path: 'standard', analytics_id: 'In Person Proofing', same_address_as_id: false

spec/features/idv/in_person_spec.rb

@@ -9,6 +9,7 @@
 
   before do
     allow(IdentityConfig.store).to receive(:in_person_proofing_enabled).and_return(true)
+    allow(IdentityConfig.store).to receive(:in_person_state_id_controller_enabled).and_return(true)
   end
 
   it 'works for a happy path', allow_browser_log: true do
@@ -38,7 +39,7 @@
         ),
       ),
     )
-    complete_state_id_step(user)
+    complete_state_id_controller(user)
 
     # ssn page
     expect_in_person_step_indicator_current_step(t('step_indicator.flows.idv.verify_info'))
@@ -290,7 +291,7 @@
     end
 
     it 'shows the address page' do
-      complete_state_id_step(user, same_address_as_id: false)
+      complete_state_id_controller(user, same_address_as_id: false)
       expect_in_person_step_indicator_current_step(t('step_indicator.flows.idv.verify_info'))
       expect(page).to have_content(t('in_person_proofing.headings.address'))
 
@@ -303,7 +304,7 @@
     end
 
     it 'can update the address page form' do
-      complete_state_id_step(user, same_address_as_id: false)
+      complete_state_id_controller(user, same_address_as_id: false)
       complete_address_step(user, same_address_as_id: false)
       complete_ssn_step(user)
       # click update address link on the verify page
@@ -328,7 +329,7 @@
     end
 
     it 'allows user to update their residential address as different from their state id' do
-      complete_state_id_step(user, same_address_as_id: true)
+      complete_state_id_controller(user, same_address_as_id: true)
       # skip address step b/c residential address is same as state id address
       complete_ssn_step(user)
 
@@ -367,6 +368,8 @@
 
     before do
       allow(IdentityConfig.store).to receive(:in_person_outage_message_enabled).and_return(true)
+      allow(IdentityConfig.store).to receive(:in_person_state_id_controller_enabled).
+        and_return(true)
     end
 
     it 'allows the user to generate a barcode despite outage', allow_browser_log: true do
@@ -410,7 +413,7 @@
       complete_location_step
 
       # state ID page
-      complete_state_id_step(user, same_address_as_id: false)
+      complete_state_id_controller(user, same_address_as_id: false)
 
       # address page
       complete_address_step(user, same_address_as_id: false)
@@ -506,7 +509,7 @@
       complete_prepare_step(user)
       complete_location_step
       # Causes the schedule USPS enrollment request to throw a bad request error
-      complete_state_id_step(user, first_name: 'usps client error')
+      complete_state_id_controller(user, first_name: 'usps client error')
       complete_ssn_step(user)
       complete_verify_step(user)
       fill_out_phone_form_ok(MfaContext.new(user).phone_configurations.first.phone)

spec/features/idv/in_person_threatmetrix_spec.rb

@@ -82,7 +82,7 @@ def deactivate_profile_update_enrollment(status:)
       complete_location_step(user)
 
       # state ID page
-      complete_state_id_step(user)
+      complete_state_id_controller(user)
 
       # ssn page
       complete_ssn_step(user, 'Reject')
@@ -170,7 +170,7 @@ def deactivate_profile_update_enrollment(status:)
       begin_in_person_proofing(user)
       complete_prepare_step(user)
       complete_location_step
-      complete_state_id_step(user)
+      complete_state_id_controller(user)
 
       # ssn page
       complete_ssn_step(user, tmx_status)

spec/features/idv/steps/in_person/verify_info_spec.rb

@@ -11,6 +11,7 @@
 
   before do
     allow(IdentityConfig.store).to receive(:in_person_proofing_enabled).and_return(true)
+    allow(IdentityConfig.store).to receive(:in_person_state_id_controller_enabled).and_return(false)
     allow_any_instance_of(ApplicationController).to receive(:analytics).and_return(fake_analytics)
     allow(user).to receive(:enrollment).
       and_return(enrollment)

spec/features/idv/steps/in_person_opt_in_ipp_spec.rb

@@ -40,7 +40,7 @@
         complete_location_step
 
         # state ID page
-        complete_state_id_step(user)
+        complete_state_id_controller(user)
 
         # ssn page
         select 'Reject', from: :mock_profiling_result
@@ -156,7 +156,7 @@
           ),
         ),
       )
-      complete_state_id_step(user)
+      complete_state_id_controller(user)
 
       # ssn page
       expect_in_person_step_indicator_current_step(t('step_indicator.flows.idv.verify_info'))
@@ -341,7 +341,7 @@
           ),
         ),
       )
-      complete_state_id_step(user)
+      complete_state_id_controller(user)
 
       # ssn page
       expect_in_person_step_indicator_current_step(t('step_indicator.flows.idv.verify_info'))

spec/support/features/in_person_helper.rb

@@ -109,7 +109,7 @@ def complete_location_step(_user = nil)
 
     # pause for the location list to disappear
     wait_for_content_to_disappear do
-      expect(page).to have_no_css('.location-collection-item')
+      expect(page).to have_no_css('.location-collection-item', wait: 1)
     end
   end
 
@@ -163,7 +163,6 @@ def complete_steps_before_state_id_step
     begin_in_person_proofing
     complete_prepare_step
     complete_location_step
-
     expect(page).to have_current_path(idv_in_person_step_path(step: :state_id), wait: 10)
   end
 
@@ -180,7 +179,7 @@ def complete_all_in_person_proofing_steps(user = user_with_2fa, tmx_status = nil
                                             same_address_as_id: true)
     complete_prepare_step(user)
     complete_location_step(user)
-    complete_state_id_step(user, same_address_as_id: same_address_as_id)
+    complete_state_id_controller(user, same_address_as_id: same_address_as_id)
     complete_address_step(user, same_address_as_id: same_address_as_id) unless same_address_as_id
     complete_ssn_step(user, tmx_status)
     complete_verify_step(user)
@@ -256,9 +255,9 @@ def perform_mobile_hybrid_steps
 
   def perform_desktop_hybrid_steps(user = user_with_2fa, same_address_as_id: true)
     perform_in_browser(:desktop) do
-      expect(page).to have_current_path(idv_in_person_step_path(step: :state_id), wait: 10)
+      expect(page).to have_current_path(idv_in_person_proofing_state_id_path, wait: 10)
 
-      complete_state_id_step(user, same_address_as_id: same_address_as_id)
+      complete_state_id_controller(user, same_address_as_id: same_address_as_id)
       complete_address_step(user, same_address_as_id: same_address_as_id) unless same_address_as_id
       complete_ssn_step(user)
       complete_verify_step(user)