Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-14220 (1): Standardize completions screen logo #11120

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Aug 20, 2024

🎫 Ticket

Partially implements LG-14220

🛠 Summary of changes

Updates consent screen to use the same heading image for both identity verified and IAL1 accounts.

📜 Testing Plan

Verify no regressions in the appearance of heading image for completions screen:

  1. Have IdP and sample application running simultaneously
  2. Go to http://localhost:9292
  3. Optional: Change "Level of service" option to "Identity-verified"
  4. Click "Sign in"
  5. Complete sign in process
  6. When at the completions screen, observe that you see the logo as in the "After" screenshot below, regardless of whether you are sharing information for an identity-verified account

👀 Screenshots

Before After
Screenshot 2024-08-20 at 4 10 53 PM Screenshot 2024-08-20 at 4 10 44 PM

changelog: User-Facing Improvements, Completions, Use standardized logo image for consent screen
Previously omitted because two possible images didn't have a common height

Better to include both width and height to avoid page relayout perceived performance
@aduth aduth requested a review from a team August 20, 2024 20:20
@aduth aduth merged commit 875ef99 into main Aug 21, 2024
2 checks passed
@aduth aduth deleted the aduth-lg-14220-consent-content-image branch August 21, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants