Simplify and standardize card styling #11177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellhenke
approved these changes
Sep 5, 2024
changelog: Internal, Code Quality, Simplify and standardize card styling
aduth
force-pushed
the
aduth-card-profile
branch
from
b09a18b
to
8d722ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates card styling to standardize around the usage of cards as stackable elements, as used in the account page and elsewhere (e.g. telephony test screen). This inverts previous assumptions of the base layout card styling as the default, which has much wider padding by default, now implementing those styles in the base layout specifically as the outlier.
In doing so, it eliminates the need for a special
profile-info-boxCSS class, since those styles are now the baseline card styling.📜 Testing Plan
Verify no visual regressions on wide and narrow viewport sizes, particularly for the base layout and account page card stylings.