Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lg 13876 seperate doc selfie into seperate forms #11194

Merged
merged 26 commits into from
Sep 13, 2024
Merged

Lg 13876 seperate doc selfie into seperate forms #11194

merged 26 commits into from
Sep 13, 2024

Conversation

AShukla-GSA
Copy link
Member

@AShukla-GSA AShukla-GSA commented Sep 4, 2024 •
edited
Loading

🎫 Ticket

Link to the relevant ticket:
LG-13876
LG-13877

🛠 Summary of changes

Created separate selfie and doc capture steps to upload different items on different pages.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

Please have SelfieCaptureEnabled set to true

  • Step 1 - Set doc_auth_separate_pages_enabled to true and go through flow successfully ensuring selfie and doc capture are on separate pages.
  • Step 2 - Set doc_auth_separate_pages_enabled to true and go through flow failing to upload a image for 1 of the docs or a selfie. Ensure failure page has all 3 uploads on the same page.
  • Step 3 - Set doc_auth_separate_pages_enabled to false and ensure all 3 uploads are on the same page.

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Before: Doc Capture and Selfie Same Page
After: Seperate Page 1 Doc Capture-1 Seperate Page 2 Selfie Seperate Page Failure

@aduth aduth mentioned this pull request Sep 5, 2024
Merged
@amirbey amirbey self-requested a review September 12, 2024 20:00
amirbey
amirbey reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@amirbey amirbey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from my testing this works as expected ... can you add automated testing for this new functionality?

solipet
solipet approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small comments on the code. Tested with both valid test data and invalid test data. LGTM!

app/javascript/packages/document-capture/components/selfie-step.tsx Outdated Show resolved Hide resolved
spec/features/idv/doc_auth/document_capture_spec.rb Outdated Show resolved Hide resolved
@AShukla-GSA AShukla-GSA merged commit 52c75be into main Sep 13, 2024
2 checks passed
@AShukla-GSA AShukla-GSA deleted the lg-13876-seperate-doc-selfie-into-seperate-forms branch September 13, 2024 20:56
@amirbey amirbey mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirbey amirbey amirbey left review comments

@aduth aduth aduth left review comments

@solipet solipet solipet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AShukla-GSA @amirbey @aduth @solipet