Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG-13665: Add option to change selected email shared with partner #11196

Merged
merged 13 commits into from
Sep 5, 2024
Merged

LG-13665: Add option to change selected email shared with partner #11196

merged 13 commits into from
Sep 5, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Sep 4, 2024

🎫 Ticket

LG-13665

🛠 Summary of changes

Adds a new flow to allow a user to change their selected email shared with a partner from their Connected Accounts dashboard screen.

📜 Testing Plan

  1. Go http://localhost:3000
  2. Sign in
  3. From account dashboard, click "Connected Accounts" in sidebar
  4. (If you don't have any connected accounts, sign in and consent using sample application)
  5. Observe:
    1. If you have selected a specific email to be changed (either from consent screen or from the following steps), it is shown
    2. Otherwise, you see "Email not yet selected"
  6. Click "Change"
  7. Change your selected email (you may need to add a second email first, unless you have "Not yet selected")
  8. Click "Submit"
  9. Repeat Step 5

👀 Screenshots

image

@aduth
LG-13665: Add option to change selected email shared with partner
f5e2e72 
changelog: Upcoming Features, Partner Shared Email, Add option to change selected email shared with partner
@aduth aduth requested a review from a team September 4, 2024 15:31
aduth
aduth commented Sep 4, 2024
View reviewed changes
spec/i18n_spec.rb Outdated
@@ -76,6 +76,7 @@ class BaseTask
{ key: 'time.formats.event_timestamp', locales: %i[zh] },
{ key: 'time.formats.full_date', locales: %i[es] }, # format is the same in Spanish and English
{ key: 'time.formats.sms_date' }, # for us date format
{ key: 'account.connected_apps.email_not_selected' }, # See: LG-?????
Copy link
Member Author

@aduth aduth Sep 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will edit this ticket number once available, before merging. We're implementing this as English-only for now, since it's behind a feature flag. The referenced ticket will implement translations once they're available.

Related Slack discussion: https://gsa-tts.slack.com/archives/C05R6BLVAQG/p1725033025669399

zachmargolis
zachmargolis approved these changes Sep 4, 2024
View reviewed changes
app/forms/select_email_form.rb Show resolved Hide resolved
app/views/accounts/_connected_app.html.erb Outdated Show resolved Hide resolved
aduth
aduth commented Sep 4, 2024
View reviewed changes
app/views/accounts/connected_accounts/selected_email/edit.html.erb Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To do: Write spec for this view. Ideally include spec covering be_logically_grouped expectations, avoiding similar regression addressed for email language in 7f4c413 & 4b256c1 .

@aduth aduth merged commit 76dee31 into main Sep 5, 2024
2 checks passed
@aduth aduth deleted the aduth-lg-13665-change-email branch September 5, 2024 11:24
@jmdembe jmdembe mentioned this pull request Sep 5, 2024
Merged
@aduth aduth mentioned this pull request Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmargolis zachmargolis zachmargolis approved these changes

@jmdembe jmdembe jmdembe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduth @zachmargolis @jmdembe