LG-14390 No longer cancel pending enrollments on logout from cancel page #11211
Conversation
shanechesnutt-ft
force-pushed
the
sc/LG-14390
branch
4 times, most recently
from
45dade6
to
54eea72
Compare
| return if !IdentityConfig.store.in_person_proofing_enabled | ||
| current_user.pending_in_person_enrollment&.update(status: :cancelled) | ||
| UspsInPersonProofing::EnrollmentHelper. | ||
| cancel_stale_establishing_enrollments_for_user(current_user) |
There was a problem hiding this comment.
It looks like you didn't need to check where the user came from (ie: Ready to Verify) after all because of this function. Before entering your password, the enrollment is establishing). Only after entering your password (before going to the PO) would the enrollment be pending. (All other's status- this function does not support ie: passed, failed, expired, and cancelled) so that is why you renamed it.
Also, method cancel_in_person_enrollment_if_exists is a dup - inside sessions_controller so further more I support this name change- each method is not exactly the same. Without testing it- I think the method in sessions_controller supports cancel your barcode. I will test on Monday to confirm.
| after :build do |user| | ||
| create(:in_person_enrollment, :establishing, user: user) | ||
| end | ||
| end |
|
Your code changes look good! I have not manually tested this. I will do so next week. |
changelog: Internal, In-person proofing, The "Exit Login.gov" button on the cancel page from the barcode step will no longer cancel user's pending enrollments.
shanechesnutt-ft
force-pushed
the
sc/LG-14390
branch
from
54eea72
to
3d01472
Compare
changelog: Internal, In-person proofing, The "Exit Login.gov" button on the cancel page from the barcode step will no longer cancel user's pending enrollments.
🎫 Ticket
Link to the relevant ticket:
LG-14390
🛠 Summary of changes
The "Exit Login.gov" button on the cancel page from the barcode step will no longer cancel user's pending enrollments.
📜 Testing Plan
Scenario: Barcode Page: "exit login.gov" button from cancel page
Scenario: During Identity Verification: "exit login.gov" button from cancel page
/verify/welcome