Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove combined-invoice-supplement-report (LG-14424) #11216

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

zachmargolis
Copy link
Contributor

Why: It has been replaced by combined-invoice-supplement-report-v2

@zachmargolis zachmargolis requested a review from a team September 6, 2024 21:04
Comment on lines -64 to +58
cron: cron_24h_1am,
cron: cron_24h,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the time change was so that we didn't run two giant tables scans simultaneously. now that we have just this report, it should be fine to move the new report earlier

Copy link
Contributor

@samathad2023 samathad2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

**Why**: It has been replaced by combined-invoice-supplement-report-v2

changelog: Internal, Reporting, Remove older report for invoices
@zachmargolis zachmargolis force-pushed the margolis-remove-old-invoice-report branch from 7339ce1 to b638236 Compare September 9, 2024 16:07
@zachmargolis zachmargolis merged commit e46966a into main Sep 9, 2024
2 checks passed
@zachmargolis zachmargolis deleted the margolis-remove-old-invoice-report branch September 9, 2024 19:04
@zachmargolis zachmargolis changed the title Remove combined-invoice-supplement-report Remove combined-invoice-supplement-report (LG-14424) Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants