Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expected analytics logging for DocAuth result #11223

Merged
merged 7 commits into from
Sep 10, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Sep 10, 2024

🛠 Summary of changes

Implements suggestion from #11220 (comment) to unexempt state_id_step_spec.rb allowed extra analytics, fixing issues exposed:

  • Doc auth mock proofing vendor didn't include all expected analytics properties
    • Fix: Include expected analytics property
  • step_count is only included for FSM implementation, but is being removed in non-FSM approach
    • Fix: Remove step_count from FSM with expectation that it's no longer needed

📜 Testing Plan

Verify build passes.

@aduth aduth requested review from a team and jmax-gsa and removed request for a team September 10, 2024 15:58
Base automatically changed from aduth-analytics-events-controller to main September 10, 2024 19:08
@aduth aduth merged commit f4c6918 into main Sep 10, 2024
2 checks passed
@aduth aduth deleted the aduth-image-upload-liveness branch September 10, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants