Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-14364 update Verified (event) in dropoff report #11234

Merged
merged 4 commits into from
Sep 13, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/reporting/drop_off_report.rb
Original file line number Diff line number Diff line change
Expand Up @@ -223,15 +223,15 @@ def dropoff_metrics_table
],
[
'Verified (event)',
idv_personal_key_submitted,
ajfarkas marked this conversation as resolved.
Show resolved Hide resolved
idv_final_resolution_verified,
ajfarkas marked this conversation as resolved.
Show resolved Hide resolved
dropoff = idv_enter_password_submitted -
idv_personal_key_submitted,
idv_final_resolution_verified,
percent(
numerator: dropoff,
denominator: idv_enter_password_submitted,
),
percent(
numerator: idv_personal_key_submitted,
numerator: idv_final_resolution_verified,
denominator: idv_started,
),
],
Expand Down Expand Up @@ -303,7 +303,7 @@ def ipp_verification_total
],
[
'Verified (event)',
'Users who confirm their personal key and complete setting up their verified account',
'Users who completed identity verification (including GPO, IPP, fraud)',
],
[
'Workflow Complete - Total Pending',
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/reporting/drop_off_report_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def expected_tables(strings: false, values: nil)
),
['Verified (event)'] + string_or_num(
strings,
*(values ? iterator.next : [4, 0, 0.0, 0.5]),
*(values ? iterator.next : [1, 3, 0.75, 0.125]),
),
['Workflow Complete - Total Pending'] + string_or_num(
strings,
Expand Down