Update specs to not ref t('devise.failure.unauthenticated')

[jessieay]

Why: This is an empty string, so will be a false positive for any
view where we expect to see it.

[hursey013]

lgtm!

[monfresh]

Is it correct to say that we are not expecting to show the user a flash message when they sign out?

[hursey013]

@monfresh we do show a flash message when someone signs out t(devise.sessions.signed_out). I believe the message referenced above is supposed to be shown when you try to access an area that requires authentication and it redirects you to the sign in page.

[monfresh]

Ah, gotcha. And in that case, we don't want to show a flash message?

[jessieay]

@monfresh Brian is correct. This is the locale we get from devise: https://github.com/plataformatec/devise/blob/f7b6d786066cef2f5e8d2ce9c6b6cc83918580eb/config/locales/en.yml#L17

Through some somewhat confusing logic, it is returned via devise here, I believe: https://github.com/plataformatec/devise/blob/88724e10adaf9ffd1d8dbfbaadda2b9d40de756a/app/controllers/devise/omniauth_callbacks_controller.rb#L8

We don't want to show it, so we set it to empty string. If we remove this customization, I see this when trying to visit my profile when signed out, for example:

[monfresh]

I understand. I only wanted to confirm that we indeed do not want to show anything if you try to access a page that requires authentication will signed out. I personally think some kind of message would be helpful.

[monfresh]

Feel free to merge if everything is working as designed. I was just thinking out loud.