Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes flash message from personal key screen #1268

Merged
merged 1 commit into from
Mar 24, 2017

Conversation

el-mapache
Copy link
Contributor

Why: The success message referred to validating your phone number,
which is nice but not necessary. It also caused content the user needs
to interact with to be pushed down farther

Old screen:

screen shot 2017-03-20 at 6 46 15 pm

New screen:

screen shot 2017-03-24 at 2 59 59 pm

**Why**: The success message refered to validating your phone number,
which is nice but not necessary. It also caused content the user needs
to interact with to be pushed down farther
Copy link
Contributor

@jessieay jessieay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! is there a GH issue for this?

@el-mapache
Copy link
Contributor Author

@jessieay Yep, should be linked now, my markdown link in the issue had wonky formatting.

@jessieay
Copy link
Contributor

@el-mapache nice - thanks for the update :) 🐵

@el-mapache el-mapache merged commit 048895c into master Mar 24, 2017
@el-mapache el-mapache deleted the ab-remove-pkey-success-alert branch March 24, 2017 20:32
pkarman pushed a commit that referenced this pull request Mar 29, 2017
**Why**: The success message refered to validating your phone number,
which is nice but not necessary. It also caused content the user needs
to interact with to be pushed down farther
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants