Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove basic account badge #1271

Merged
merged 2 commits into from
Mar 27, 2017
Merged

Remove basic account badge #1271

merged 2 commits into from
Mar 27, 2017

Conversation

hursey013
Copy link
Member

Why: Opt to instead show a "Verified" badge only.

@@ -142,21 +142,5 @@
it { expect(partial).to eq('profile/verified_account_badge') }
end
end

describe '#basic_account_partial' do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move this method from the decorator as well, then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops thought I got that, just pushed update.

Copy link
Contributor

@jessieay jessieay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! squash n' merge when green 🍏

@hursey013 hursey013 merged commit bebfc08 into master Mar 27, 2017
@hursey013 hursey013 deleted the bh-remove-basic-badge branch March 27, 2017 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants