Disable personal key session timeout JS spec #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd vote to remove + create a ticket instead of set to pending. I prefer to have no pending tests since they tend to just sit there. We've had the same pending tests in the suite since I started on this project many months ago...doesn't add much value IMO. |
el-mapache
reviewed
Mar 29, 2017
There was a problem hiding this comment.
Like @jessieay, removing might make more sense. Maybe we can link a new ticket to the but ticket you opened the other day? I am planning on pushing up a unit test with that PR fairly soon.
**Why**: It is failing intermittently and we have not yet figured out why. Having to restart Travis builds slows down the PR review process, so for now, we're removing the test.
monfresh
force-pushed
the
mb-disable-js-modal-test
branch
from
c2cf29c
to
457ba5f
Compare
|
Removed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: It is failing intermittently and we have not yet figured out
why. Having to restart Travis builds slows down the PR review process,
so for now, we're disabling the test.