Properly line up scissors on pkey page in Safari #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: The icon appears to be getting set incorrectly because of a CSP violation. It used an inline style, and safari seems to be more stringent about that compared with other browsers.
hursey013
approved these changes
Mar 31, 2017
|
@hursey013 Yeah I think as long as people's mail clients aren't also checking for these kinds of violations we'll be 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: The icon appears to be getting set incorrectly because of a CSP
violation. It used an inline style, and safari seems to be more
stringent about that compared with other browsers.
Can be tested manually with the following steps:
1). Use any recent branch of identity-idp except for this one (as those branches will contain inline styles on the scissor icon).
2). Comment out line 38 of
config/initializers/secure_headers.rb3). (Re)Start your server.
4). Visit the personal key screen in Safari. You should see something like this:
If you open the console, you'll also see a CSP violation for inline-styles
5). Check out this branch and visit the personal key screen in safari. You'll see the icon lined up nicely with the dotted border, as it appears in other browsers.
🎉