Prevent accordion events from firing twice #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
el-mapache
force-pushed
the
ab-accordion-click-fix
branch
2 times, most recently
from
2f65924
to
1083e16
Compare
**Why**: Using a `javascript_include_tag` to include a JS file with an `import` statement ends up including all other code that the imported file imports. This reduces the usefulness of using an import statement with browserify, as that code should be shared, not compiled/included multiple times. The simplest solution is to rely on the `Modal` class ref stored on the window object.
**Why**: Passing specs are good specs
el-mapache
force-pushed
the
ab-accordion-click-fix
branch
from
1083e16
to
50ae13c
Compare
pkarman
approved these changes
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: Using a
javascript_include_tagto include a JS file with animportstatement ends up including all other code that the importedfile imports. This reduces the usefulness of using an import statement
with browserify, as that code should be shared, not compiled/included
multiple times. The simplest solution is to rely on the
Modalclassref stored on the window object.