Refactor: separate controller actions for separate personal key views #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessieay
force-pushed
the
jy-personal-key-controller-refactor
branch
from
497593e
to
4285dff
Compare
*WHY**: We were showing the personal key modal in 3 separate places, but redirecting users to a single controller action after all 3, which was kind of confusing.
jessieay
changed the title
monfresh
reviewed
Apr 4, 2017
| if current_user.password_reset_profile.present? | ||
| reactivate_profile_path | ||
| else | ||
| profile_path |
There was a problem hiding this comment.
CC says this is not tested.
|
@monfresh darn missed that comment before merging (I thought I refreshed the tab and only saw comments from Zach...but anyway, will add a test for that line in a follow up PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY: We were showing the personal key modal in 3 separate places, but
redirecting users to a single controller action after all 3, which was
kind of confusing.