Updates footer link name #1337
Updates footer link name #1337
Conversation
**Why** Because the past name was inaccurate; the linked page now contains security policy information along with privacy information.
config/locales/links/en.yml
Outdated
| @@ -12,7 +12,7 @@ en: | |||
| auth_app_fallback_html: ' or %{link}.' | |||
| fallback_to_sms_html: Send me a text message with the code instead | |||
| fallback_to_voice_html: If you can't get text message right now, you can get a security code via %{link} | |||
| privacy_policy: Privacy Policy | |||
| privacy_policy: Privacy & security | |||
There was a problem hiding this comment.
Can we use and instead of the ampersand?
There was a problem hiding this comment.
We could - the ampersand was intended to save a little space on the mobile version of the footer. Say more about why you'd like the full word!
There was a problem hiding this comment.
Oh -- did I forget to escape-ify it?
There was a problem hiding this comment.
yes the & needs HTML-escaping if we use it. I've seen mixed use on the site, and I personally like the longhand better.
There was a problem hiding this comment.
these things are auto HTML-escaped, so don't worry about escaping that here
There was a problem hiding this comment.
@jeanninehunter Your guidance would be appreciated! & or and ?
There was a problem hiding this comment.
@pkarman Done! Changed to and. Since @jeanninehunter has lowered the gavel, that is now our style everywhere.
**Why** Because that's our style.
|
@esgoodman this looks like it just needs a test adjusted to reflect the new link text - want me to update it for you? |
|
Please do @hursey013! I always forget to change the test. |
Why Because the previous version was inaccurate; the linked page now contains security policy information along with privacy information.