Use application layout as default layout
#1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**WHY**: * This is more standard in Rails * Before, we were using `card` everywhere, which also rendered `application` * This also slightly refactors how we deal with rendering flash messages. We should only be showing standard flashes. Others are used to pass around boolean values but do not need to be rendered.
zachmargolis
approved these changes
Apr 12, 2017
app/views/shared/_flashes.html.slim
Outdated
| @@ -0,0 +1,4 @@ | |||
| - if flash.any? | |||
| - flash.to_hash.slice("alert", "error", "notice", "success", "warning").each do |type, message| | |||
There was a problem hiding this comment.
should we put these keys in a constant somewhere?
monfresh
reviewed
Apr 14, 2017
| @@ -1,6 +1,8 @@ | |||
| class ApplicationController < ActionController::Base | |||
| include UserSessionContext | |||
|
|
|||
| FLASH_KEYS = %w[alert error notice success warning].freeze | |||
There was a problem hiding this comment.
What do you think about using the add_flash_types Rails convention instead? http://api.rubyonrails.org/classes/ActionController/Flash/ClassMethods.html
That way, we won't need to slice this array in shared/_flashes.
There was a problem hiding this comment.
sure, works for me! create an issue for that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY:
cardeverywhere, which also renderedapplicationmessages. We should only be showing standard flashes. Others are used
to pass around boolean values but do not need to be rendered.