Return timestamp in Profile events list #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**WHY**: Users should be able to see the time AND date for events in their account history.
config/locales/event_types/en.yml
Outdated
| @@ -9,3 +9,4 @@ en: | |||
| email_changed: Email address changed | |||
| phone_changed: Phone number changed | |||
| phone_confirmed: Phone confirmed | |||
| timestamp: '%{date} at %{time} (Eastern)' | |||
There was a problem hiding this comment.
This key is very specific to eastern time, can we put that in the key name somewhere? timestamp_eastern ?
| def to_s | ||
| I18n.t( | ||
| 'event_types.timestamp', | ||
| date: eastern_timestamp.strftime('%B %e, %Y'), |
There was a problem hiding this comment.
Maybe a good use for I18n.l?
# some translation.yml
en:
time:
formats:
date: '%B %e, %Y'
time: '%-l:%M %p'I18n.t(
'event_types.timestamp',
date: I18n.l(eastern_timestamp, format: :date),
time: I18n.l(eastern_timestamp, format: :time)
)And I know on our ticket we specified full "Eastern" but I think we could get close with "%Z":
en:
time:
formats:
event_timestamp: "%B %e, %Y at %-l:%M %p (%Z)"I18n.l(eastern_timestamp, format: :event_timestamp)There was a problem hiding this comment.
COOL! love that use of I18n.l
done here: f8f0212
note that I went without the %z since that output an integer and @andrewhughey was pretty clear in the GH issue that he wanted "Eastern" for clarity.
There was a problem hiding this comment.
Sorry I meant capital '%Z' which is EST but yeah totally understood about full "Eastern"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY: Users should be able to see the time AND date for events in their account history.