Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create generic lockout message #1378

Merged
merged 2 commits into from
Apr 19, 2017
Merged

Create generic lockout message #1378

merged 2 commits into from
Apr 19, 2017

Conversation

jessieay
Copy link
Contributor

WHY: When a user tries to log in when locked out, we know they are
locked out but we don't know if it is because of entering an OTP or
personal key too many times.

Previously, we were hardcoding the "OTP" lockout message. Now, we are
displaying a generic message telling them that they are locked out.

@@ -115,6 +115,8 @@ en:
That security code is invalid. You can try entering it again or request a new
one-time security code.
invalid_personal_key: That personal key is invalid.
max_generic_login_attempts_reached: >
Your account is temporarily locked.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jeanninehunter can you take a look at this and let me know if the copy is OK? See PR description for context on when a user would see this message

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jessieay, to say "Your account is temprarily locked." But, should we offer guidance on why it's locked? Should we also add, "Did you enter the correct personal key?" OR "Your account is temporarily locked. Did you enter the right personal key?" OR "Your account is temporaily locked. Try re-entering your personal key."

@@ -115,6 +115,8 @@ en:
That security code is invalid. You can try entering it again or request a new
one-time security code.
invalid_personal_key: That personal key is invalid.
max_generic_login_attempts_reached: >
Your account is temporarily locked.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jessieay, to say "Your account is temprarily locked." But, should we offer guidance on why it's locked? Should we also add, "Did you enter the correct personal key?" OR "Your account is temporarily locked. Did you enter the right personal key?" OR "Your account is temporaily locked. Try re-entering your personal key."

@jessieay
Copy link
Contributor Author

@jeanninehunter we do not know whether it is locked because they entered a personal key too many times or an OTP too many times. Either way, they cannot re-enter the personal key or OTP until the lockout period expires, so I am not sure we would want to prompt them to re-enter on this page. Does that make sense?

Copy link
Contributor

@jeanninehunter jeanninehunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for acknowledging ??s raised @jessieay. Cool w/ moving fwd on PR.

**WHY**: When a user tries to log in when locked out, we know they are
locked out but we don't know if it is because of entering an OTP or
personal key too many times.

Previously, we were hardcoding the "OTP" lockout message. Now, we are
displaying a generic message telling them that they are locked out.
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessieay jessieay merged commit 2906d26 into master Apr 19, 2017
@jessieay jessieay deleted the jy-generic-lockout branch April 19, 2017 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants