Use npm for Basscss CSS framework #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sure this is a super obvious question, but can we just use v 4.0 and remove 3 entirely? |
|
@el-mapache yeah, that's what I would have preferred, but the It's definitely possible, it just wouldn't be a drop in solution. |
|
that is indeed a lot of breaking changes |
el-mapache
approved these changes
May 4, 2017
zachmargolis
approved these changes
May 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of Basscss in the
vendor/folder was a custom combination ofv3.0.0andv4.0.0. This PR removes thevendor/dependency and uses npm to importv3.0.0. All that remains invendor/are the necessary stylesheets fromv4.0.0.