Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content on /verify/ #1422

Merged
merged 1 commit into from
May 10, 2017
Merged

Update content on /verify/ #1422

merged 1 commit into from
May 10, 2017

Conversation

gemfarmer
Copy link
Contributor

@gemfarmer gemfarmer commented May 9, 2017

Addresses confusion around the LOA3 verification flow. I made content changes based on this comment by @esgoodman.

Previous confusing text. "Your letter is on its way" and "Send letter" don't make sense together

screen shot 2017-05-09 at 2 35 17 pm


Updated version

screen shot 2017-05-09 at 2 36 04 pm


"Your letter is on its way" still flashes after you send letter

screen shot 2017-05-09 at 3 05 20 pm

Copy link
Member

@hursey013 hursey013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only small nitpick would be to move idv.titles.mail.sent to the idv.messages section since its no longer being used as the page title.

Copy link
Contributor

@esgoodman esgoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gemfarmer
Copy link
Contributor Author

@hursey013 Good suggestion. I'll make that change

Copy link
Member

@hursey013 hursey013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@gemfarmer gemfarmer merged commit 52171ca into master May 10, 2017
@gemfarmer gemfarmer deleted the bsh-usps-mail-flow branch May 10, 2017 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants