Return SP user to branded page when canceling #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monfresh
commented
May 18, 2017
| @@ -13,4 +13,4 @@ p.mt-tiny.mb0#email-description = t('instructions.registration.email') | |||
|
|
|||
| = f.button :submit, t('forms.buttons.submit.default'), class: 'btn-wide mb4' | |||
|
|
|||
| = render 'shared/cancel', link: root_path | |||
| = render 'shared/cancel', link: decorated_session.cancel_link_url | |||
There was a problem hiding this comment.
Look, ma: no conditionals! Thanks, @jessieay 😄
**Why**: If a user came from a Service Provider, then clicks "Create Account", and clicks "Cancel", they should be taken back to the branded page they saw originally, as opposed to the non-branded home page. Note that this only fixes the link on one page. Fixes for the links on subsequent pages in the account creation flow will come in a separate PR.
monfresh
force-pushed
the
mb-cancel-returns-to-branded-page
branch
from
056dc30
to
5e6fbc8
Compare
zachmargolis
approved these changes
May 18, 2017
| click_link t('sign_up.registrations.create_account') | ||
| click_link t('links.cancel') | ||
|
|
||
| expect(current_url).to eq sign_up_start_url(request_id: sp_request_id) |
There was a problem hiding this comment.
should we do a check on the content of the page for the SP name?
There was a problem hiding this comment.
We could, but that's already tested elsewhere. The SP name is looked up based on the request_id. So, since we're already testing that the correct request_id is being included in the URL, we can safely assume the correct SP name will be displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: If a user came from a Service Provider, then clicks
"Create Account", and clicks "Cancel", they should be taken back
to the branded page they saw originally, as opposed to the non-branded
home page.
Note that this only fixes the link on one page. Fixes for the links
on subsequent pages in the account creation flow will come in a separate
PR.