Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errors to FormResponse in PersonalKeyForm #1450

Merged
merged 1 commit into from
May 24, 2017

Commits on May 24, 2017

  1. Add errors to FormResponse in PersonalKeyForm

    **Why**: To better adhere to our conventions of returning an error
    object from from objects
    
    Return regex object from PersonalKeyFormatter
    
    **Why**: The method .regexp on PersonalKeyFormatter seems like it should
    return an actual regex and not a string
    
    **How**: Make two methods, one for use by ruby, returning the object,
    and one for use on the client, returning a string.
    
    Use class methods instead of new
    
    **Why**: This is simpler, instantiation wasn't really needed
    el-mapache committed May 24, 2017
    Configuration menu
    Copy the full SHA
    beaaee6 View commit details
    Browse the repository at this point in the history