Adjust password strength checker copy #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if its worth it to write an integration test for this...maybe if we go through and audit all the copy at some point? |
hursey013
reviewed
May 23, 2017
|
Right you are, removed! |
|
Oops, spoke too soon, looks like that's one of the few strings that we have hardcoded into a test. |
|
Ugh yes. Just updated! |
|
Good to go. |
el-mapache
force-pushed
the
ab-change-password-strength-copy
branch
from
f8c67c3
to
4407c74
Compare
**Why**: The new copy reads better!
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: The new copy reads better!
Screenshot: