LG-4254: Fix SVG scaling in Internet Explorer #5076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmargolis
approved these changes
May 19, 2021
| next if %w[vendor node_modules].include?(relative_path.split('/')[1]) | ||
|
|
||
| files = Dir.glob('{app,public}/**/*.svg', base: Rails.root) | ||
| files.reject! { |f| f.start_with? 'public/assets/' } |
There was a problem hiding this comment.
how come we're rejecting files in this directory?
There was a problem hiding this comment.
Unless I'm mistaken, they're just compiled copies (duplicates) of app/assets files.
There was a problem hiding this comment.
Unless I'm mistaken, they're just compiled copies (duplicates) of
app/assetsfiles.
And: Their presence was causing failures for me locally, likely due to stale assets from an older precompile.
aduth
force-pushed
the
aduth-lg-4254-svg-scale
branch
from
5f6999d to
5a07614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: So that images don't appear distorted.
Regression of #4635, due to default behavior of SVG optimizer to remove
viewBoxattribute affecting scaling in Internet Explorer.Related:
Implementation notes:
viewBoxattribute inspec/svg_spec.rbpiv-cac-round.svgandstate-id-round.svg, defunct after LG-4382 Remove PIV/CAC from IAL2 flow as proofing option #4819