Reimplement timeout countdown as custom element #6023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
commented
Mar 2, 2022
zachmargolis
approved these changes
Mar 2, 2022
aduth
force-pushed
the
aduth-countdown-component
branch
from
efb324e
to
3667619
Compare
|
Performance impact on
Overall pretty small in terms of absolute numbers, but architecturally feels better to split out this way to limit scope of the pack. That, plus other benefits listed in original comment still apply. |
**Why**: - Reduce size and scope of hot-path application pack - Avoid relying on window globals (LoginGov.countdownTimer), since they rely on fragile dependency order - Improve testability of element behavior in isolation - Allow reuse for common countdown behavior changelog: Internal, Optimziation, Reduce size of common JavaScript file
Avoid passing from view See: #6023 (comment)
- Simplify tests to avoid accounting for newline - Because it's single, simple tag See: #6023 (comment)
**Why**: Avoid errors in runtime
Seemingly more compatible with element lifecycle, where dataset can be undefined prior to element being connected. For example, when `define`-ing the custom element, the attributeChangedCallback is triggered, but the element isn't yet mounted.
Example snippets often use getter syntax, since it's better supported in older browsers. But since we transpile, and since reasonably new browsers support static variables, we can update to simplify. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/static
**Why**: To restore previous behavior of screen reader atomic announcement including time remaining.
aduth
force-pushed
the
aduth-countdown-component
branch
from
2029c03
to
0c4c4e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
applicationpackLoginGov.countdownTimer), since they rely on fragile dependency orderThere is not expected to be any functional behavior differences with these revisions.