Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved activity query out of private function #19

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

bilaliqbalr
Copy link
Contributor

Moved activity query out of private function to let users modify query as per their need

@199ocero
Copy link
Owner

199ocero commented Jan 31, 2024

Hey @bilaliqbalr thanks for this suggestion, can you explain what's the use case for this? I know you want to modify the query of the spatie activity model and customize what is the query but could you give me an example why you need it? I make it as a private so that it will not be modified as intended. It will only show the records that needed to show in the timeline component. You can also configure the state via the configuration() method.

https://filamentphp.com/plugins/jaocero-activity-timeline#configuration

@199ocero 199ocero self-requested a review January 31, 2024 10:20
@bilaliqbalr
Copy link
Contributor Author

bilaliqbalr commented Jan 31, 2024

Hi @199ocero
I have a use case that I wanted to use it under User Resource and wanted to show all user activities, regardless of the cause.
Also, on some other pages I need to apply filters i.e, causer, event, date.

@bilaliqbalr
Copy link
Contributor Author

@199ocero

@199ocero 199ocero merged commit ac3869b into 199ocero:main Feb 3, 2024
@199ocero
Copy link
Owner

199ocero commented Feb 3, 2024

Done @bilaliqbalr . Thank you for your contribution. With this, you can now customize the query that suites to your needs. Thank youu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants