Added Cargo crate exclude paths #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
complexspaces
approved these changes
Sep 21, 2024
There was a problem hiding this comment.
tests folder is probably only used in a development environment and is not that helpful for the dependents.
This seems reasonable to me, for the time being. Quite often crate consumers will run their dependency's tests (especially if they have custom toolchains) but since there's only a single WASM-specific test in the tests/ directory I don't think that's worth much to anyone.
|
Thanks for the improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.githubfolder is definitely unnecessary for the dependents of the library.examplesfolder might be helpful for some developers, but I don't think that many people inspect the sources downloaded from crates.io and viewing this folder will always be easy on GitHub.testsfolder is probably only used in a development environment and is not that helpful for the dependents.Excluding these folders from the Cargo crate will reduce the network and disk space consumption and lead to more concise file structure for the crate.