Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_reconnect_url to Client #252

Merged
merged 7 commits into from
Jun 14, 2023
Merged

Add set_reconnect_url to Client #252

merged 7 commits into from
Jun 14, 2023

Conversation

tyilo
Copy link
Contributor

@tyilo tyilo commented Nov 1, 2022

No description provided.

@1c3t3a
Copy link
Owner

1c3t3a commented Jan 15, 2023

Sorry for the late review and thanks for the patch! I don't really understand this patch though, why do we need this instead of setting a different address when we create the builder? This doesn't give any benefit in my eyes.

@tyilo
Copy link
Contributor Author

tyilo commented Jan 15, 2023

Sorry for the late review and thanks for the patch! I don't really understand this patch though, why do we need this instead of setting a different address when we create the builder? This doesn't give any benefit in my eyes.

I forgot to link it, but this fixes #251 where I have described why I need this feature.

@tyilo
Copy link
Contributor Author

tyilo commented May 26, 2023

Ping @1c3t3a

Cargo.lock Outdated Show resolved Hide resolved
socketio/src/client/client.rs Outdated Show resolved Hide resolved
ci/socket-io-restart-url-auth.js Outdated Show resolved Hide resolved
ci/socket-io-restart-url-auth.js Outdated Show resolved Hide resolved
socketio/src/client/client.rs Outdated Show resolved Hide resolved
socketio/src/client/client.rs Outdated Show resolved Hide resolved
socketio/src/client/client.rs Outdated Show resolved Hide resolved
socketio/src/client/client.rs Outdated Show resolved Hide resolved
@1c3t3a
Copy link
Owner

1c3t3a commented Jun 12, 2023

Sorry for the delay!! I have some comments :) Can you please also rebase and resolve the merge conflicts?

@tyilo
Copy link
Contributor Author

tyilo commented Jun 12, 2023

Rebased and updated the code.

@tyilo tyilo requested a review from 1c3t3a June 12, 2023 13:46
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #252 (d3eeae4) into main (e6e1ae6) will increase coverage by 0.21%.
The diff coverage is 96.03%.

❗ Current head d3eeae4 differs from pull request most recent head 684e497. Consider uploading reports for the commit 684e497 to get more accurate results

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   90.90%   91.12%   +0.21%     
==========================================
  Files          37       37              
  Lines        4629     4719      +90     
==========================================
+ Hits         4208     4300      +92     
+ Misses        421      419       -2     
Impacted Files Coverage Δ
socketio/src/client/builder.rs 92.56% <ø> (ø)
socketio/src/client/client.rs 97.18% <95.60%> (-0.37%) ⬇️
socketio/src/lib.rs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

socketio/src/client/client.rs Outdated Show resolved Hide resolved
socketio/src/client/client.rs Outdated Show resolved Hide resolved
socketio/src/client/client.rs Outdated Show resolved Hide resolved
socketio/src/client/client.rs Outdated Show resolved Hide resolved
socketio/src/client/client.rs Outdated Show resolved Hide resolved
socketio/src/client/client.rs Show resolved Hide resolved
socketio/src/client/client.rs Show resolved Hide resolved
Copy link
Owner

@1c3t3a 1c3t3a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Thanks you!

@1c3t3a 1c3t3a merged commit d5759d1 into 1c3t3a:main Jun 14, 2023
@tyilo
Copy link
Contributor Author

tyilo commented Jun 14, 2023

Thanks for merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants