-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set_reconnect_url to Client #252
Conversation
Sorry for the late review and thanks for the patch! I don't really understand this patch though, why do we need this instead of setting a different address when we create the builder? This doesn't give any benefit in my eyes. |
I forgot to link it, but this fixes #251 where I have described why I need this feature. |
Ping @1c3t3a |
Sorry for the delay!! I have some comments :) Can you please also rebase and resolve the merge conflicts? |
Rebased and updated the code. |
Codecov Report
@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 90.90% 91.12% +0.21%
==========================================
Files 37 37
Lines 4629 4719 +90
==========================================
+ Hits 4208 4300 +92
+ Misses 421 419 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) Thanks you!
Thanks for merging :) |
No description provided.