-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to handle events that expect an ack #463
base: main
Are you sure you want to change the base?
Conversation
I didn't add any tests because I didn't have the time to do it yet. But I've tested locally with my usecase and it seems to work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: rename added internal functions to ..._with_awk (rather than having _no_awk variants)
suggestion: add tests so the feature continues to be tested and working
after that it looks good
/// | ||
/// let client = ClientBuilder::new("http://localhost:4200/") | ||
/// .namespace("/admin") | ||
/// .on_any(|event, payload, client, ack_id| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// .on_any(|event, payload, client, ack_id| { | |
/// .on_any_with_ack(|event, payload, client, ack_id| { |
@@ -25,7 +25,7 @@ pub struct Packet { | |||
pub packet_type: PacketId, | |||
pub nsp: String, | |||
pub data: Option<String>, | |||
pub id: Option<i32>, | |||
pub id: Option<AckId>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I'm generally a fan of wrapper types, it's not worth the breaking API change.
This adds three new methods to the API surface
[Raw]Client::ack(AckId, D)
ClientBuilder::on_with_ack(Event, callback)
ClientBuilder::on_any_with_ack(Event, callback)
using these it's possible to receive messages that require ack and acknowledge them
Fixes #461