Bump addon to manifest v3

Due to manifest incompatibilities between Mozilla and Chrome different
packages are built for each browser vendor.

.github/workflows/release.yaml

@@ -2,10 +2,6 @@ name: Build release
 
 on:
   push:
-    tags:
-      - 'v*'
-    branches:
-      - main
 
 jobs:
   main:
@@ -32,15 +28,15 @@ jobs:
         run: tools/package
 
         # ref: https://github.com/actions/upload-artifact
-      - name: Upload build artifact
-        uses: actions/upload-artifact@v2
+      - name: Upload build artifacts
+        uses: actions/upload-artifact@v4
         with:
-          name: json-bookmarks.zip
-          path: out/json-bookmarks-*.zip
+          name: json-bookmarks
+          path: out/
 
       # ref: https://github.com/softprops/action-gh-release
       - name: Create release
         uses: softprops/action-gh-release@v1
-        if: startsWith(github.ref, 'refs/tags/')
+        if: startsWith(github.ref, 'refs/tags/v')
         with:
           files: out/json-bookmarks-*.zip

background.js

@@ -1,3 +1,5 @@
-browser.browserAction.onClicked.addListener((tab) => {
+// Entrypoint for extension in Mozilla which only supports background script in
+// manifest version 3.
+browser.action.onClicked.addListener((tab) => {
   browser.tabs.create({ url: "bookmarks.html" });
-});
+});

manifest.chrome.json.in

@@ -0,0 +1,22 @@
+{
+  "manifest_version": 3,
+  "name": "Json Bookmarks",
+  "version": "${version}",
+  "homepage_url": "https://github.com/1nfiniteloop/json-bookmarks",
+  "description": "Import and export bookmarks between browsers with a json file",
+  "permissions": ["bookmarks"],
+  "action": {
+    "default_title": "JSON Bookmarks"
+  },
+  "icons": {
+    "16": "icon/16.png",
+    "32": "icon/32.png",
+    "48": "icon/48.png",
+    "96": "icon/96.png",
+    "128": "icon/128.png"
+  },
+  "background": {
+    "service_worker": "service_worker.js",
+    "type": "module"
+  }
+}

manifest.json.in → manifest.mozilla.json.in

@@ -1,11 +1,16 @@
 {
-  "manifest_version": 2,
+  "manifest_version": 3,
   "name": "Json Bookmarks",
   "version": "${version}",
   "homepage_url": "https://github.com/1nfiniteloop/json-bookmarks",
   "description": "Import and export bookmarks between browsers with a json file",
+  "browser_specific_settings": {
+  "gecko": {
+    "id": "{c46bac9d-a680-46b9-ab8f-15dc7f5a8c71}"
+    }
+  },
   "permissions": ["bookmarks"],
-  "browser_action": {
+  "action": {
     "default_title": "JSON Bookmarks"
   },
   "icons": {

service_worker.js

@@ -0,0 +1,7 @@
+// Entrypoint for extension in Chrome which only supports service workers in
+// manifest version 3.
+import "./third_party/browser-polyfill.min.js";
+
+browser.action.onClicked.addListener((tab) => {
+  browser.tabs.create({ url: "bookmarks.html" });
+});

tools/package

@@ -1,4 +1,5 @@
 #!/bin/bash
+set -ue
 
 readonly ext_name="json-bookmarks"
 
@@ -13,16 +14,30 @@ get_mainfest_version()
   echo "${semver#v}"
 }
 
-create_manifest()
+create_manifest_for()
 {
-  version="$(get_mainfest_version)" envsubst < manifest.json.in > manifest.json
+  browser_vendor="${1}"
+  version="$(get_mainfest_version)" envsubst < manifest.${browser_vendor}.json.in > manifest.json
 }
 
-create_manifest \
-  && mkdir --parents out/ \
-  && zip \
+create_package_for()
+{
+  browser_vendor="${1}"
+  create_manifest_for "${browser_vendor}"
+  mkdir --parents "out/"
+  zip \
     --recurse-paths \
     --filesync \
-    out/${ext_name}-$(get_version).zip \
-    * \
-    --exclude .git icon/src/\* out/\* TODO.md manifest.json.in
+    out/${ext_name}-${browser_vendor}-$(get_version).zip \
+    bookmark \
+    icon \
+    third_party \
+    *.js \
+    *.html \
+    *.css \
+    LICENSE \
+    manifest.json
+}
+
+create_package_for "mozilla"
+create_package_for "chrome"