Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with ivy-occur #8

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Fix compatibility with ivy-occur #8

merged 1 commit into from
Mar 29, 2021

Conversation

Gleek
Copy link
Contributor

@Gleek Gleek commented Feb 19, 2021

- Updates `ivy--old-cands‘ with the result of counsel-jq (Fixes 200ok-ch#7)
- Configurable buffer name and binary
@Gleek
Copy link
Contributor Author

Gleek commented Feb 24, 2021

Hey @munen, did you get the time to look at this?

@Gleek
Copy link
Contributor Author

Gleek commented Mar 25, 2021

Hello @munen, reminder for this. Let me know in case you want some different implementation.

@munen
Copy link
Contributor

munen commented Mar 29, 2021

Hi @Gleek

Looks good to me, great work!

Good thinking for also making the counsel-jq-command configurable. This makes it easy to switch to yq instead of jq to work on json and yml files! I'll add some documentation for that.

Thank you, again and apologies for the latency on getting back to you. The last two months have been quite challenging.

🙏 🙇

@munen munen merged commit 7a360c6 into 200ok-ch:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gives wrong results with ivy-occur
2 participants